Added service.instance.id into resource env #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
pavolloffay
reviewed
Oct 25, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
TylerHelmuth
approved these changes
Oct 31, 2023
jpkrohling
reviewed
Nov 2, 2023
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
frzifus
approved these changes
Nov 14, 2023
jaronoff97
approved these changes
Nov 14, 2023
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Added service.instance.id into resource env Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed ServiceInstanceID following the RFC4122 Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Changed ServiceInstanceID following the RFC4122 Signed-off-by: Yuri Sa <yurimsa@gmail.com> * Added semantic conventions Signed-off-by: Yuri Sa <yurimsa@gmail.com> --------- Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added the service.instance.id as os.Hostname into the traces resource Env.
Link to tracking Issue:
#1921
Testing:
Changed the unit tests to include the
service.instance.idinformation.Documentation: