Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add service.instance.id into resource env #1921

Closed
Duncan-dsf opened this issue Jul 13, 2023 · 2 comments
Closed

add service.instance.id into resource env #1921

Duncan-dsf opened this issue Jul 13, 2023 · 2 comments
Assignees
@yuriolisa
Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request

Comments

@Duncan-dsf
Copy link

Why not add service.instance.id into resources? Is there any consideration?

opentelemetry-operator/pkg/instrumentation/sdk.go

Line 324 in 02b4d30

func (i *sdkInjector) createResourceMap(ctx context.Context, otelinst v1alpha1.Instrumentation, ns corev1.Namespace, pod corev1.Pod, index int) map[string]string {

image
@TylerHelmuth TylerHelmuth added enhancement New feature or request area:auto-instrumentation Issues for auto-instrumentation labels Jul 14, 2023
@TylerHelmuth
Copy link
Member

We could. Is that something you'd like to contribute.

@yuriolisa
Copy link
Contributor

I can take this on, ok?

@yuriolisa yuriolisa mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriolisa yuriolisa

Labels
area:auto-instrumentation Issues for auto-instrumentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TylerHelmuth @Duncan-dsf @yuriolisa