fix: add java17 as compatible runtime in collector makefile #1667
+36
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkan-ozal
reviewed
Jan 16, 2025
collector/Makefile
Outdated
| @@ -47,12 +47,12 @@ package: build | |||
|
|
|||
| .PHONY: publish | |||
| publish: | |||
| aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text | |||
| aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 java17 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text | |||
There was a problem hiding this comment.
Can you add java21 too
tylerbenson
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
In addition to @serkan-ozal's request, I suggest adding a comment to each language's layer publish workflow that points here, encouraging any updates to be applied in both places.
a68db58 to
ca30dc6
Compare
|
@arun-annamalai can you revert changes in the go.mod files as they are irrelevant to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1666