Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(detectors): use values from semantic-conventions package #704

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

meteorlxy
Copy link
Contributor

Currently opentelemetry-resource-detector-alibaba-cloud package maintains some semconv locally. Now as @opentelemetry/semantic-conventions@1.0.0 has been released, we could migrate those values to that package.

@meteorlxy meteorlxy requested a review from a team October 18, 2021 08:10
@github-actions github-actions bot requested a review from legendecas October 18, 2021 08:10
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #704 (a88f500) into main (f5851e7) will not change coverage.
The diff coverage is n/a.

❗ Current head a88f500 differs from pull request most recent head 4200783. Consider uploading reports for the commit 4200783 to get more accurate results

@@           Coverage Diff           @@
##             main     #704   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files           9        9           
  Lines         638      638           
  Branches      126      126           
=======================================
  Hits          618      618           
  Misses         20       20           

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
These values are also hardcoded in the .test.ts file for this detector, for example here

Can be a good time to update those as well if you are up to it :)

@meteorlxy
Copy link
Contributor Author

Can be a good time to update those as well if you are up to it :)

Updated

@legendecas
Copy link
Member

The step "Post Cache Dependencies" step of action "browser-tests" failed for the following messages: (link)

Error: .github/workflows/unit-test.yml (Line: 145, Col: 16):
Error: The template is not valid. .github/workflows/unit-test.yml (Line: 145, Col: 16): hashFiles('**/package.json') couldn't finish within 120 seconds.

Rerunning the actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants