-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(detectors): use values from semantic-conventions package #704
Conversation
Codecov Report
@@ Coverage Diff @@
## main #704 +/- ##
=======================================
Coverage 96.86% 96.86%
=======================================
Files 9 9
Lines 638 638
Branches 126 126
=======================================
Hits 618 618
Misses 20 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These values are also hardcoded in the .test.ts
file for this detector, for example here
Can be a good time to update those as well if you are up to it :)
Updated |
The step "Post Cache Dependencies" step of action "browser-tests" failed for the following messages: (link)
Rerunning the actions. |
Currently
opentelemetry-resource-detector-alibaba-cloud
package maintains some semconv locally. Now as@opentelemetry/semantic-conventions@1.0.0
has been released, we could migrate those values to that package.