refactor(detectors): use values from semantic-conventions package (#704)

* refactor(detectors): use values from semantic-conventions package * chore: tweaks
open-telemetry · Oct 21, 2021 · 61190bc · 61190bc
1 parent 096b694
commit 61190bc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 30 deletions.
diff --git a/...de/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts b/...de/opentelemetry-resource-detector-alibaba-cloud/src/detectors/AlibabaCloudEcsDetector.ts
@@ -19,12 +19,12 @@ import {
   Resource,
   ResourceDetectionConfig,
 } from '@opentelemetry/resources';
-import { SemanticResourceAttributes } from '@opentelemetry/semantic-conventions';
-import * as http from 'http';
 import {
-  CloudProviderValues,
   CloudPlatformValues,
-} from '../semantic-conventions';
+  CloudProviderValues,
+  SemanticResourceAttributes,
+} from '@opentelemetry/semantic-conventions';
+import * as http from 'http';
 
 /**
  * The AlibabaCloudEcsDetector can be used to detect if a process is running in

diff --git a/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/semantic-conventions.ts b/detectors/node/opentelemetry-resource-detector-alibaba-cloud/src/semantic-conventions.ts
diff --git a/...ntelemetry-resource-detector-alibaba-cloud/test/detectors/AlibabaCloudEcsDetector.test.ts b/...ntelemetry-resource-detector-alibaba-cloud/test/detectors/AlibabaCloudEcsDetector.test.ts
@@ -17,6 +17,7 @@
 import * as nock from 'nock';
 import * as assert from 'assert';
 import { Resource } from '@opentelemetry/resources';
+import { CloudProviderValues } from '@opentelemetry/semantic-conventions';
 import { alibabaCloudEcsDetector } from '../../src';
 import {
   assertCloudResource,
@@ -69,7 +70,7 @@ describe('alibabaCloudEcsDetector', () => {
       assert.ok(resource);
 
       assertCloudResource(resource, {
-        provider: 'alibaba_cloud',
+        provider: CloudProviderValues.ALIBABA_CLOUD,
         accountId: 'my-owner-account-id',
         region: 'my-region-id',
         zone: 'my-zone-id',