chore: remove unused commitlint and husky #1824
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
.husky/...
config was removed from the contrib repo, again because its DX is just annoying, and unnecessary given the "pr-title" CI workflow.Currently, the husky and commitlint deps remain in the contrib repo, but they are not used -- except to add some minor annoyances in some dev cases (some examples are below).
This PR removes vestiges of husky and commitlint.
some minor annoyances from the lingering husky and commitlint
Since a recent update of commitlint to a version that requires Node.js 18, when using Node.js 16,
npm ci
starts out with a wall of EBADENGINE warnings:In a clean clone (e.g. after
git clean -ffdx
), runningnpm install --package-lock-only
fails because of the husky usage in the "prepare" script: