Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lint PR titles #1068

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jun 22, 2022

Some PR authors (especially new ones) often don't know that PR titles should be conventional commit messages. This adds a lint check to both let those authors know and also to ensure we dont accidentally merge a PR before it is properly named.

@dyladan dyladan requested a review from a team June 22, 2022 19:24
@dyladan dyladan changed the title chore: lint PR titles test lint PR titles Jun 22, 2022
@dyladan dyladan changed the title test lint PR titles chore: lint PR titles Jun 22, 2022
@dyladan
Copy link
Member Author

dyladan commented Jun 22, 2022

Looks like this when it fails:

image

@dyladan dyladan changed the title chore: lint PR titles ci: lint PR titles Jun 22, 2022
@dyladan
Copy link
Member Author

dyladan commented Jun 22, 2022

Editing the PR title immediately reruns the check without requiring another push and full test run

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome. 👍

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #1068 (51f54c9) into main (a5eecff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1068   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files          13       13           
  Lines         856      856           
  Branches      178      178           
=======================================
  Hits          821      821           
  Misses         35       35           

Copy link
Member

@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dyladan dyladan merged commit f9e81b0 into open-telemetry:main Jun 23, 2022
@dyladan dyladan deleted the lint-pr-title branch June 23, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants