Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for escaping declarative config env var substitution #7033

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Jan 17, 2025

Implementation of spec PR: open-telemetry/opentelemetry-specification#4375

# given STR=val
key: ${STR}                           # yields key: val
key: ${UNKNOWN:-val}        # yields key: val
key: $${STR}                         # yields key: ${STR}   <-- NEW
key: $${UNKNOWN:-val}      # yields key: ${UNKNOWN:-val} <-- NEW

@jack-berg jack-berg requested a review from a team as a code owner January 17, 2025 23:02
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.89%. Comparing base (31869a3) to head (d7bcc24).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7033   +/-   ##
=========================================
  Coverage     89.88%   89.89%           
  Complexity     6655     6655           
=========================================
  Files           748      748           
  Lines         20077    20081    +4     
  Branches       1969     1970    +1     
=========================================
+ Hits          18047    18052    +5     
  Misses         1435     1435           
+ Partials        595      594    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant