Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirements for contrib instrumentations #3505

Open
2 of 5 tasks
mateuszrzeszutek opened this issue Jul 6, 2021 · 2 comments
Open
2 of 5 tasks

Requirements for contrib instrumentations #3505

mateuszrzeszutek opened this issue Jul 6, 2021 · 2 comments

Comments

@mateuszrzeszutek
Copy link
Member

mateuszrzeszutek commented Jul 6, 2021

This issue tracks all requirements/dependencies that we have to implement to be able to extract instrumentation to the contrib repo.

It might be a good idea to stabilize at least a part of testing-common too, those instrumentations have to have tests after all.

@iNikem
Copy link
Contributor

iNikem commented Sep 10, 2021

What about instrumentation-api-annotation-support and instrumentation-api-caching? Is making them stable required for proper contrib experience?

@mateuszrzeszutek
Copy link
Member Author

instrumentation-api-caching is a part of instrumentation-api (it shouldn't be released at all, it's baked into the instrumentation-api lib) so it's required.
We probably don't have to make instrumentation-api-annotation-support stable yet, it's only used in those instrumentations that do something with annotations (e.g. @WithSpan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants