Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL Java Instrumentation #4270

Closed
jord1e opened this issue Oct 2, 2021 · 2 comments · Fixed by #5583
Closed

Add GraphQL Java Instrumentation #4270

jord1e opened this issue Oct 2, 2021 · 2 comments · Fixed by #5583
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation

Comments

@jord1e
Copy link
Contributor

jord1e commented Oct 2, 2021

Is your feature request related to a problem? Please describe.
GraphQL Java is an essential library for building GraphQL API’s in Java and Kotlin (and other JVM languages, of course).

It powers the following projects:

The library needs proper observability.

Describe the solution you'd like
Javaagent and native instrumentation added to OpenTelemetry.
Instrumentation is already present for JavaScript and Ruby, go instrumentation has been proposed

Considering the fact that no semantic conventions have yet to be adopted, I propose we reuse the span names/events used by the NodeJS OpenTelemetry instrumentation.

Describe alternatives you've considered
N/A

Additional context
I would be prepared to create a pull request to add javaagent instrumentation, please let me know if this is acceptable.
This will probably take some time. I expect to have time beginning next month.
Considering that java-instrumentation-contrib guidelines aren’t yet clear I will create the PR in this repository.

@jord1e jord1e added the enhancement New feature or request label Oct 2, 2021
@anuraaga
Copy link
Contributor

anuraaga commented Oct 3, 2021

Thanks @jord1e - this seems like important instrumentation and I think this repo is appropriate. A PR would be greatly appreciated - but please start with what we call library instrumentation which would implement that Instrumentation hook. Especially when the library provides the hook, we prioritize using it, since javaagent then just auto-registers the library instrumentation. Would that be ok for you?

@jord1e
Copy link
Contributor Author

jord1e commented Oct 3, 2021

I will look into it somewhere this week or next week and come back with a formal proposal.
The new instrumentation label is probably appropriate for this issue, right?

@iNikem iNikem added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Oct 4, 2021
@jord1e jord1e changed the title Add GraphQL Java instrumentation Add GraphQL Java Instrumentation Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome enhancement New feature or request new instrumentation
Projects
None yet
4 participants