Add two new maintainers and an approver #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Jul 7, 2021
README.md
Outdated
| - [Pablo Collins](https://github.com/pmcollins), Splunk | ||
| - [Ryan Fitzpatrick](https://github.com/rmfitzpatrick), Splunk (maintainer) | ||
|
|
||
| Maintainers ([@open-telemetry/java-instrumentation-maintainers](https://github.com/orgs/open-telemetry/teams/java-instrumentation-maintainers)): |
There was a problem hiding this comment.
Hmm, does java-contrib have its own approver/maintainer groups? Should we reuse the instrumentation repo ones here?
There was a problem hiding this comment.
Contrib has its own, but adding the instrumentation team as a member to it seems to make sense to me.
There was a problem hiding this comment.
oops this was just copy-paste, fixed
I ran into problem with using sub-teams, where the members of the sub-teams couldn't invite new people to the parent team, which I later found out was captured by:
- Every member of foo-maintainers should be included in foo-approvers and foo-triagers explicitly, with the "Maintainer" GitHub privileges. This allows repository maintainers to invite new approvers and triagers to the team.
|
@rmfitzpatrick can you change @anuraaga and my role to
and I will set up the new folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose adding @iNikem and @mateuszrzeszutek as maintainers and @laurit as approver for this repository, since we are planning to move many instrumentations over here in the future (open-telemetry/opentelemetry-java-instrumentation#3505), and also so that we start getting more visibility and reviews of changes happening in this repo, e.g. #48