-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vanity imports to internal packages #2280
Add vanity imports to internal packages #2280
Conversation
Looks like |
Is this still being worked on? It seems like the upstream PR mentioned was merged. |
@MrAlias I still need to add support to skip |
@mx-psi does this need to be done all at once, or can it be done in stages? |
64711ea
to
d68d940
Compare
This comment has been minimized.
This comment has been minimized.
@MovieStoreGuy We can do it on stages if we exclude directories, happy to do it in whichever way works best for you |
I think the easiest is to do all at once so next PRs can have the check, doing it progressively might take longer and there will be some rework as new added code in the meantime can go without vanity imports. |
@mx-psi 0.4.0 is out https://github.com/jcchavezs/porto/tree/v0.4.0. Thank you! |
Codecov Report
@@ Coverage Diff @@
## main #2280 +/- ##
=======================================
- Coverage 73.6% 73.6% -0.1%
=======================================
Files 175 175
Lines 12419 12419
=======================================
- Hits 9147 9144 -3
- Misses 3039 3041 +2
- Partials 233 234 +1
|
This adds vanity imports on internal files, excluding autogenerated and third party files. It was generated by running
porto -w --include-internal .
withporto
version 0.4.0.It fixes #2279.