Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanity imports are not checked on internal packages #2279

Closed
mx-psi opened this issue Oct 7, 2021 · 1 comment · Fixed by #2280
Closed

Vanity imports are not checked on internal packages #2279

mx-psi opened this issue Oct 7, 2021 · 1 comment · Fixed by #2280
Labels
bug Something isn't working
Milestone

Comments

@mx-psi
Copy link
Member

mx-psi commented Oct 7, 2021

The current CI checks vanity import comments on exported packages via porto. Internal packages and modules are not checked, meaning that one can accidentally introduce incorrect vanity import comments, which break some tools like gomobile.

To avoid breaking those builds there are two options:

  1. remove vanity import comments on internal packages and add a check to avoid introducing more or
  2. add vanity import comments on internal packages and add a check for these.

I opened jcchavezs/porto#11 to implement option (2) but I want to get confirmation from OpenTelemetry Go maintainers that they are okay with this solution.

@Aneurysm9
Copy link
Member

I'm fine with option 2.

@pellared pellared moved this to Closed in Go: Triage Nov 2, 2023
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants