You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current CI checks vanity import comments on exported packages via porto. Internal packages and modules are not checked, meaning that one can accidentally introduce incorrect vanity import comments, which break some tools like gomobile.
To avoid breaking those builds there are two options:
remove vanity import comments on internal packages and add a check to avoid introducing more or
add vanity import comments on internal packages and add a check for these.
I opened jcchavezs/porto#11 to implement option (2) but I want to get confirmation from OpenTelemetry Go maintainers that they are okay with this solution.
The text was updated successfully, but these errors were encountered:
The current CI checks vanity import comments on exported packages via
porto
. Internal packages and modules are not checked, meaning that one can accidentally introduce incorrect vanity import comments, which break some tools likegomobile
.To avoid breaking those builds there are two options:
I opened jcchavezs/porto#11 to implement option (2) but I want to get confirmation from OpenTelemetry Go maintainers that they are okay with this solution.
The text was updated successfully, but these errors were encountered: