-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.5.0 #1921
Release v1.5.0 #1921
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1921 +/- ##
=======================================
+ Coverage 72.2% 78.8% +6.5%
=======================================
Files 123 129 +6
Lines 5325 5395 +70
=======================================
+ Hits 3848 4253 +405
+ Misses 1365 1014 -351
- Partials 112 128 +16
|
I'm not planning to fix the example test because #1920 will remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Non-blocking, but probably issue worthy: I noticed that the samplers didn't have a version.go
. I don't know if we want to keep up with including one for every package, as it just makes these reviews harder, or if we want to change it (for the non-stable packages).
* Added Reason to Contributing and Updated TracerConfig * PR comment fixup * Changed how span Options work. * Fix Markdown linting * Added meter configs. * Fixes from PR comments * fix for missing instrument Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
I'll add one here for consistency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Blocked on #1920
Added
go.opentelemetry.io/contrib/samplers/jaegerremote
package.This package implements the Jaeger remote sampler for OpenTelemetry Go. (Add Jaeger remote sampler #936)
go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws
package now have the appropriate database attributes added for the operation being performed.These attributes are detected automatically, but it is also now possible to provide a custom function to set attributes using
WithAttributeSetter
. (otelaws: adding dynamodb attributes #1582)go.opentelemetry.io/contrib/propagators/ot
. (Implemented logic for Opentracing baggage propagation #1880)Fixed
echo
middleware by usingSpanKind.SERVER
when deciding theSpanStatus
.This makes
4xx
response codes to not be an error anymore. ([otelecho] Use SpanStatusFromHTTPStatusCodeAndSpanKind on the middleware #1848)