Added google cloud function resource detector #1584

patil-kshitij · 2022-01-13T12:48:51Z

Added google cloud-function resource detector
Added following attributes -

projectID
region
functionName
cloud.provider
cloud.platform

…-go-contrib into main

linux-foundation-easycla · 2022-01-13T12:48:55Z

The committers are authorized under a signed CLA.

✅ Kshitij Patil (9eecabd, bc17e7e, c64cd2a, 0edacc4, a2de50a)

detectors/gcp/cloud-function.go

codecov · 2022-01-13T14:43:48Z

Codecov Report

Merging #1584 (5fd26ff) into main (9e8d62b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #1584     +/-   ##
=======================================
+ Coverage   70.3%   70.5%   +0.1%     
=======================================
  Files        128     129      +1     
  Lines       5537    5564     +27     
=======================================
+ Hits        3898    3925     +27     
  Misses      1500    1500             
  Partials     139     139

Impacted Files	Coverage Δ
detectors/gcp/cloud-function.go	`100.0% <100.0%> (ø)`

detectors/gcp/cloud-function.go

return nil,nil when not on cloud-function

dashpole

Can you add unit tests? They should be very similar to the cloud run unit tests: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/detectors/gcp/cloud-run_test.go#L82

detectors/gcp/cloud-function.go

patil-kshitij · 2022-01-14T15:39:57Z

Can you add unit tests? They should be very similar to the cloud run unit tests: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/detectors/gcp/cloud-run_test.go#L82

Okay, will add unit test cases.

patil-kshitij · 2022-01-18T05:22:10Z

Can you add unit tests? They should be very similar to the cloud run unit tests: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/detectors/gcp/cloud-run_test.go#L82

Hi @dashpole ,
Have added unit test cases,
Can you please review ?

patil-kshitij · 2022-01-18T15:46:32Z

Hi @dashpole ,
Can you please approve for workflows ?

patil-kshitij · 2022-01-18T16:33:32Z

Hi @Aneurysm9
Can you please review ?

detectors/gcp/cloud-function.go

detectors/gcp/cloud-function_test.go

Aneurysm9

Please add a CHANGELOG.md entry for this addition.

MrAlias

The initialization of the CloudFunction type needs to be addressed before we can merge this.

detectors/gcp/cloud-function.go

detectors/gcp/cloud-function_test.go

MrAlias · 2022-02-17T16:43:21Z

@patil-kshitij are you still able to work on this and apply the feedback?

patil-kshitij · 2022-02-18T04:48:35Z

@patil-kshitij are you still able to work on this and apply the feedback?

Sure, @MrAlias , will work on the feedback and apply those changes

…-go-contrib into main

patil-kshitij · 2022-02-28T08:24:31Z

Please add a CHANGELOG.md entry for this addition.

Hi @Aneurysm9 , have added changelog, can you please review ?

CHANGELOG.md

detectors/gcp/cloud-function.go

hanyuancheung

lgtm, a little suggestion!

hanyuancheung · 2022-03-04T16:48:02Z

CHANGELOG.md

@@ -13,6 +13,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

 - DynamoDB spans created with the `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws` package will now have the appropriate database attributes added for the operation being performed.
  These attributes are detected automatically, but it is also now possible to provide a custom function to set attributes using `WithAttributeSetter`. (#1582)
+- Add resource detector for GCP cloud function.


Suggested change

- Add resource detector for GCP cloud function.

- Add resource detector for GCP cloud function. (#1584)

hanyuancheung · 2022-03-04T16:59:54Z

detectors/gcp/cloud-function.go

+	gcpFunctionNameKey = "K_SERVICE"
+)
+
+// NewCloudFunction will return a GCP Cloud Function resource detector.


Suggested change

// NewCloudFunction will return a GCP Cloud Function resource detector.

// NewCloudFunction returns a GCP Cloud Function resource detector.

patil-kshitij added 5 commits January 13, 2022 15:35

adding cloud function detector

9eecabd

Merge branch 'open-telemetry:main' into main

bc17e7e

linting changes

c64cd2a

Merge branch 'main' of https://github.com/patil-kshitij/opentelemetry…

0edacc4

…-go-contrib into main

changed a function name

a2de50a

patil-kshitij requested review from Aneurysm9, dashpole, evantorrie, jmacd, MadVikingGod, MrAlias, paivagustavo, pellared and XSAM as code owners January 13, 2022 12:48

dashpole reviewed Jan 13, 2022

View reviewed changes

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

dashpole self-assigned this Jan 13, 2022

dashpole reviewed Jan 13, 2022

View reviewed changes

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

using cloudrun implementation for getting projectID and region

289405d

return nil,nil when not on cloud-function

patil-kshitij requested a review from dashpole January 14, 2022 14:25

dashpole reviewed Jan 14, 2022

View reviewed changes

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

using provided context

29088d3

patil-kshitij requested a review from dashpole January 14, 2022 15:20

adding unit test cases

99ee757

dashpole approved these changes Jan 18, 2022

View reviewed changes

ran make pre-commit

31995f5

Aneurysm9 reviewed Jan 18, 2022

View reviewed changes

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

detectors/gcp/cloud-function_test.go Show resolved Hide resolved

incorporated review comment

e36628b

Aneurysm9 approved these changes Jan 19, 2022

View reviewed changes

Merge branch 'main' into main

a24189f

MrAlias requested changes Feb 3, 2022

View reviewed changes

patil-kshitij added 3 commits February 21, 2022 16:46

Merge branch 'open-telemetry:main' into main

02b313a

incorporating review comments.

42d53c2

Merge branch 'main' of https://github.com/patil-kshitij/opentelemetry…

25d54bc

…-go-contrib into main

patil-kshitij requested a review from hanyuancheung as a code owner February 28, 2022 06:03

patil-kshitij added 3 commits February 28, 2022 11:35

Merge branch 'open-telemetry:main' into main

ef027ae

added changelog

a306e77

Making cloudFunction struct private

bf4a657

MrAlias reviewed Feb 28, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

MrAlias reviewed Feb 28, 2022

View reviewed changes

detectors/gcp/cloud-function.go Outdated Show resolved Hide resolved

patil-kshitij added 2 commits March 1, 2022 11:10

incorporating review comments

a329bfd

Merge branch 'open-telemetry:main' into main

cc29e15

patil-kshitij requested a review from MrAlias March 2, 2022 04:19

anupamdalmia10 mentioned this pull request Mar 2, 2022

fix: add missing platform and cloud provider values #1857

Open

Merge branch 'main' into main

5fd26ff

MrAlias approved these changes Mar 4, 2022

View reviewed changes

MrAlias merged commit 6ee1fdd into open-telemetry:main Mar 4, 2022

hanyuancheung approved these changes Mar 4, 2022

View reviewed changes

MrAlias mentioned this pull request Mar 16, 2022

Release v1.5.0 #1921

Merged

pellared added this to the untracked milestone Nov 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added google cloud function resource detector #1584

Added google cloud function resource detector #1584

patil-kshitij commented Jan 13, 2022

linux-foundation-easycla bot commented Jan 13, 2022 •

edited

Loading

codecov bot commented Jan 13, 2022 •

edited

Loading

dashpole left a comment

patil-kshitij commented Jan 14, 2022

patil-kshitij commented Jan 18, 2022

patil-kshitij commented Jan 18, 2022

patil-kshitij commented Jan 18, 2022

Aneurysm9 left a comment

MrAlias left a comment

MrAlias commented Feb 17, 2022

patil-kshitij commented Feb 18, 2022

patil-kshitij commented Feb 28, 2022

hanyuancheung left a comment

hanyuancheung Mar 4, 2022

hanyuancheung Mar 4, 2022

	- Add resource detector for GCP cloud function.
	- Add resource detector for GCP cloud function. (#1584)

	// NewCloudFunction will return a GCP Cloud Function resource detector.
	// NewCloudFunction returns a GCP Cloud Function resource detector.

Added google cloud function resource detector #1584

Added google cloud function resource detector #1584

Conversation

patil-kshitij commented Jan 13, 2022

linux-foundation-easycla bot commented Jan 13, 2022 • edited Loading

codecov bot commented Jan 13, 2022 • edited Loading

Codecov Report

dashpole left a comment

Choose a reason for hiding this comment

patil-kshitij commented Jan 14, 2022

patil-kshitij commented Jan 18, 2022

patil-kshitij commented Jan 18, 2022

patil-kshitij commented Jan 18, 2022

Aneurysm9 left a comment

Choose a reason for hiding this comment

MrAlias left a comment

Choose a reason for hiding this comment

MrAlias commented Feb 17, 2022

patil-kshitij commented Feb 18, 2022

patil-kshitij commented Feb 28, 2022

hanyuancheung left a comment

Choose a reason for hiding this comment

hanyuancheung Mar 4, 2022

Choose a reason for hiding this comment

hanyuancheung Mar 4, 2022

Choose a reason for hiding this comment

linux-foundation-easycla bot commented Jan 13, 2022 •

edited

Loading

codecov bot commented Jan 13, 2022 •

edited

Loading