Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticConventions: update link to v1.21.0 tag #4659

Merged
merged 4 commits into from
Jul 14, 2023
Merged

SemanticConventions: update link to v1.21.0 tag #4659

merged 4 commits into from
Jul 14, 2023

Conversation

TimothyMothra
Copy link
Contributor

Design discussion issue #4484

Changes

  • Update all semantic convention links to the v1.21.0 tag.
    The semantic-conventions repo completed their first release of v1.21.0.
    I would rather link to a tagged version of the specs than the main branch.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@TimothyMothra TimothyMothra requested a review from a team July 14, 2023 20:18
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #4659 (83ae531) into main (18f7978) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 83ae531 differs from pull request most recent head 1be5a56. Consider uploading reports for the commit 1be5a56 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4659      +/-   ##
==========================================
+ Coverage   84.96%   85.00%   +0.03%     
==========================================
  Files         314      314              
  Lines       12715    12715              
==========================================
+ Hits        10803    10808       +5     
+ Misses       1912     1907       -5     
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 90.47% <ø> (ø)
...AspNetCore/Implementation/HttpInMetricsListener.cs 64.70% <ø> (ø)
...tp/Implementation/HttpHandlerDiagnosticListener.cs 68.42% <ø> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 75.75% <ø> (ø)
...plementation/HttpWebRequestActivitySource.netfx.cs 80.86% <ø> (ø)
...ation.SqlClient/SqlClientInstrumentationOptions.cs 98.87% <ø> (ø)
src/Shared/HttpSemanticConventionHelper.cs 80.00% <ø> (ø)

... and 5 files with indirect coverage changes

@utpilla utpilla merged commit 4a3b97f into open-telemetry:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants