-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantic conventions for grpc client #4658
Update semantic conventions for grpc client #4658
Conversation
@TimothyMothra Would you be able to add changelog and comments to this as part of your PR? |
@vishweshbankwar please update the description here describing what attributes changed. |
I updated the grpc changelog in my PR #4659. |
src/OpenTelemetry.Instrumentation.GrpcNetClient/Implementation/GrpcClientDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.GrpcNetClient/Implementation/GrpcClientDiagnosticListener.cs
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
test/OpenTelemetry.Instrumentation.Grpc.Tests/GrpcTests.client.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4658 +/- ##
==========================================
- Coverage 85.08% 84.97% -0.11%
==========================================
Files 314 314
Lines 12715 12723 +8
==========================================
- Hits 10819 10812 -7
- Misses 1896 1911 +15
|
…/github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/update-grpc-client-instrumentation
Towards #4484
Design discussion issue #
• update the GRPC client library attributes.
net.peer.ip -> server.socket.address
net.peer.name -> server.address
net.peer.port -> server.port
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes