Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand OtlpMetricExporter tests #2670

Merged
merged 16 commits into from
Nov 24, 2021
Merged

Expand OtlpMetricExporter tests #2670

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
706f49e
Simplify ToOtlpResourceMetricsTest
alanwest Nov 23, 2021
79d3877
Simplify ToOtlpResourceMetricsTest
alanwest Nov 23, 2021
d27c32c
Test OTLP gauge transform
alanwest Nov 23, 2021
390a7af
Test OTLP sum transform
alanwest Nov 23, 2021
3da7f95
Test OTLP histogram transform
alanwest Nov 23, 2021
008b9be
Fix OTLP histogram transform bug
alanwest Nov 23, 2021
643b895
Remove unused parameter
alanwest Nov 23, 2021
5cd22bc
Merge branch 'main' into alanwest/otlp-metrics-tests
cijothomas Nov 23, 2021
177acaf
Remove unused parameter
alanwest Nov 23, 2021
7e7cfdb
Merge branch 'alanwest/otlp-metrics-tests' of github.com:alanwest/ope…
alanwest Nov 24, 2021
0b329f2
Can't set attributes on observable gauges
alanwest Nov 24, 2021
898b74d
Remove metricReader local variable
alanwest Nov 24, 2021
82992f6
Fix formatting
alanwest Nov 24, 2021
c551930
Fix formatting take 2
alanwest Nov 24, 2021
67e022a
Validate bucket counts
alanwest Nov 24, 2021
d83e19c
Merge branch 'main' into alanwest/otlp-metrics-tests
cijothomas Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/MetricItemExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,8 @@ internal static OtlpMetrics.Metric ToOtlpMetric(this Metric metric)
};

AddAttributes(metricPoint.Tags, dataPoint.Attributes);
dataPoint.Count = (ulong)metricPoint.LongValue;
dataPoint.Sum = metricPoint.DoubleValue;
dataPoint.Count = (ulong)metricPoint.GetHistogramCount();
dataPoint.Sum = metricPoint.GetHistogramSum();

foreach (var histogramMeasurement in metricPoint.GetHistogramBuckets())
{
Expand Down
Loading