Expand OtlpMetricExporter tests #2670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cijothomas
reviewed
Nov 23, 2021
|
|
||
| var testCompleted = false; | ||
| var attributes = ToAttributes(keysValues).ToArray(); |
There was a problem hiding this comment.
Yep you're right. I removed it . No way to set attributes using ObservableGauge right?
There was a problem hiding this comment.
Observable can also have attributes! See this example
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/docs/metrics/learning-more-instruments/Program.cs#L56
There was a problem hiding this comment.
reyang
reviewed
Nov 23, 2021
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpMetricsExporterTests.cs
Outdated
Show resolved
Hide resolved
…ntelemetry-dotnet into alanwest/otlp-metrics-tests
Codecov Report
@@ Coverage Diff @@
## main #2670 +/- ##
==========================================
+ Coverage 82.25% 82.93% +0.67%
==========================================
Files 249 249
Lines 8688 8688
==========================================
+ Hits 7146 7205 +59
+ Misses 1542 1483 -59
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes