-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter] add fix for prometheus exporter build #1795
Conversation
|
As of now, CI build is failing for #1791, this PR can be merged once the build is fixed. |
216bdfd
to
bcc4932
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
52a2723
to
648ea79
Compare
@rochaudhari - CI test is failing for code formatting. Can you fix the formatting as suggested here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CONTRIBUTING.md#how-to-send-pull-requests |
Signed-off-by: Roshan Chaudhari rochaudhari@nvidia.com
a01354f
to
3e483a4
Compare
Strange! After running format.sh as well, the file looks same. I updated the patch again. |
@lalitb Can we merge this? |
@rochaudhari, I'll prepare the release this weekend. |
Signed-off-by: Roshan Chaudhari rochaudhari@nvidia.com
Fixes #1728
For prometheus exporter, required dependencies are not loaded in repository.bzl. When Opentelemetry is imported in some other project, these dependencies are missing.