-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Exporter] add fix for prometheus exporter build #1729
Conversation
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 85.79% 85.77% -0.01%
==========================================
Files 171 171
Lines 5212 5212
==========================================
- Hits 4471 4470 -1
- Misses 741 742 +1
|
@rgc183 Thanks for the fix. You would need to sign the CLA before you can contribute. Also, need to fix the code format as described here - https://github.com/open-telemetry/opentelemetry-cpp/blob/main/CONTRIBUTING.md#how-to-send-pull-requests |
@rgc183 Thanks for the fix. Please fix the clang-format (extra line), see from the build logs:
And please sign the CLA. |
@rgc183 - let us know if you need help with formatting, or have issues with CLA signing? |
@lalitb Please give me sometime, I am working with my organization to get CLA approval and some sign-offs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after CLA signed,
@lalitb As a corporate contributor, when I select my organization, there is list of people I see as CLA managers. I do not see how to add new person to send an email to. Also, the person mentioned in the list, I cannot locate him internally. |
Created another MR: #1795 from my corporate account. Closing this one. |
Fixes # (issue)
For prometheus exporter, required dependencies are not loaded in repository.bzl. When Opentelemetry is imported in some other project, these dependencies are missing.