Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] See if contrib tests break with a panic on configopaque fmt.Stringer impl #9268

Closed
wants to merge 2 commits into from
Closed

[TEST] See if contrib tests break with a panic on configopaque fmt.Stringer impl #9268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
338f3a5
[TEST] See if contrib tests break with a panic on configopaque fmt.St…
mx-psi Jan 11, 2024
13dc5ba
Run panic on separate goroutine to prevent recovery
mx-psi Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/configopaque/opaque.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,6 @@ func (s String) MarshalText() ([]byte, error) {
}

func (s String) String() string {
go func() { panic("testing if this is called somewhere else") }()
return maskedString
}
2 changes: 1 addition & 1 deletion config/configopaque/opaque_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestStringFmt(t *testing.T) {
examples := []String{"opaque", "s", "veryveryveryveryveryveryveryveryveryverylong"}
for _, example := range examples {
// nolint S1025
assert.Equal(t, "[REDACTED]", fmt.Sprintf("%s", example))
assert.Panics(t, func() { fmt.Sprintf("%s", example) })
// converting to a string allows to output as an unredacted string still:
// nolint S1025
assert.Equal(t, string(example), fmt.Sprintf("%s", string(example)))
Expand Down
Loading