Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] See if contrib tests break with a panic on configopaque fmt.Stringer impl #9268

Closed

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 11, 2024

Description: A quick way to test implications of #9214

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 11, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Jan 11, 2024

From https://pkg.go.dev/fmt#hdr-Format_errors:

If an Error or String method triggers a panic when called by a print routine, the fmt package reformats the error message from the panic, decorating it with an indication that it came through the fmt package. For example, if a String method calls panic("bad"), the resulting formatted message will look like

🙃 I am going to run the panic on a separate goroutine, since this way it can't be caught by recover

@mx-psi
Copy link
Member Author

mx-psi commented Jan 11, 2024

Alright, contrib tests are passing so it seems like there are no other usages of configopaque.String String method anywhere in contrib tests. That makes me a bit more certain that we have caught all usages

@mx-psi mx-psi closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant