[featuregate] Deprecate NewFlag in favor of RegisterFlags #8727
Conversation
Codecov ReportAttention:
... and 6 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
|
I think I need to simplify things. I will drop this requirement to run this with a CLI flag since it's so impractical and work my way with a programmatic change so I can test strict mode in a test. We can stop this, we're trying to make it work but it's just impractical and I have exhausted enough good will with this attempt. |
|
@atoulme I understand your frustration, but please don't close others PRs without checking with them, especially when is not an obvious reason :) |
|
@bogdandrutu Oh I meant to help close this because @mx-psi only opened it to make my own PR whole as we're going for 1.0. No harm done. Just trying to make it explicit to @mx-psi his help is deeply appreciated, but I need to relieve him from his duty of pushing this work in ahead of the 1.0 release of featuregate. I'll go close my original PR as well. |
|
Understood! I'll leave it be then. But I can decorrelate the work on strict mode from flags, for now at least. |
|
@atoulme @TylerHelmuth @djaglowski @MovieStoreGuy PR changed a bit after back and forth with Bogdan, mind taking another look? |
**Description:** Removes deprecated function `featuregate.NewFlag`. This PR MUST NOT be merged before v0.89.0 is released. **Link to tracking Issue:** Follow up to #8727
Description:
Deprecate
featuregate.NewFlagin favor ofRegistry.RegisterFlags, which registers flags into a provided flagset.The intent is to unblock future development of new features such as #7991 without incurring into deprecations or breaking changes to implement these.
This will allow us to do a 1.0 release.
Link to tracking Issue: Relates to #8220