Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release featuregate 1.0 #8220

Closed
mx-psi opened this issue Aug 11, 2023 · 4 comments
Closed

Release featuregate 1.0 #8220

mx-psi opened this issue Aug 11, 2023 · 4 comments
Labels
area:featuregate discussion-needed Community discussion needed priority:p1 High

Comments

@mx-psi
Copy link
Member

mx-psi commented Aug 11, 2023

The featuregate module milestone has been completed for three months at time of writing. None of the remaining open issues related to featuregate seem like a blocker for GA for me.

This issue is for discussing if there are any blockers not listed on the issue tracker to release a 1.0 version of this module, and, if not, release this module. At time of writing this would be our first 1.0 module.

A 1.0 release would honor our stability guarantees.
@mx-psi mx-psi added discussion-needed Community discussion needed priority:p1 High area:featuregate labels Aug 11, 2023
@atoulme
Copy link
Contributor

atoulme commented Aug 14, 2023

I would like to see #7804 addressed first as #7991 introduces an API breaking change.

@mx-psi mx-psi mentioned this issue Oct 23, 2023
Merged
@mx-psi
Copy link
Member Author

mx-psi commented Oct 23, 2023

I would like to see #7804 addressed first as #7991 introduces an API breaking change.

I propose merging #8727 which is the breaking change on #7991; that way we can address #7804 after 1.0 if needed without having breaking changes.

@mx-psi mx-psi mentioned this issue Oct 27, 2023
Merged
@mx-psi
Copy link
Member Author

mx-psi commented Oct 27, 2023

#8766 may be necessary for 1.0

bogdandrutu pushed a commit that referenced this issue Nov 6, 2023
@mx-psi
[featuregate] Deprecate NewFlag in favor of RegisterFlags (#8727)
1dd5ac3 
**Description:** 

Deprecate `featuregate.NewFlag` in favor of `Registry.RegisterFlags`,
which registers flags into a provided flagset.

The intent is to unblock future development of new features such as
#7991 without incurring into deprecations or breaking changes to
implement these.
This will allow us to do a 1.0 release.

**Link to tracking Issue:** Relates to #8220
mx-psi added a commit that referenced this issue Nov 7, 2023
@mx-psi
[featuregate] Validate arguments to Register (#8766)
8bea0d3 
**Description:**
- Validate Gate IDs: ids must be alphanumeric with dots. At a minimum we
have to disallow `,` to avoid ambiguity in the CLI, but I am being
intentionally more restrictive here
- Validate URLs: we check that a valid URL can be built from it using
the `net/url` stdlib package
- Validate versions: we check that a valid version is passed to the
`To/FromVersion` options using hashicorp's libraries and also that the
implicit version range, when defined, is not empty.

This does not change the public API types, it only adds validation.

Relates to #8220

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Alex Boten <aboten@lightstep.com>
@mx-psi
Copy link
Member Author

mx-psi commented Nov 17, 2023

I am going to close this one in favor of #8946, which follows the template from #8935

@mx-psi mx-psi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:featuregate discussion-needed Community discussion needed priority:p1 High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atoulme @mx-psi