split configgrpc, confighttp, and config/internal #7921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7921 +/- ##
==========================================
- Coverage 91.12% 91.05% -0.07%
==========================================
Files 298 298
Lines 14912 14912
==========================================
- Hits 13588 13578 -10
- Misses 1047 1057 +10
Partials 277 277 ☔ View full report in Codecov by Sentry. |
c39f29f to
e4640d4
Compare
These are the last of the config packages. Fixes open-telemetry#7895 Signed-off-by: Alex Boten <aboten@lightstep.com>
b67540b to
0c43061
Compare
dmitryax
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last of the config packages. Fixes #7895
I decided to submit these last 3 modules together to reduce review cycles. The use of the
internalmodule is a result of the conversation w/ @mx-psi here: #7895 (comment)Follow up to #7910