split config/configauth module #7910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a902c43 to
ca0c241
Compare
jpkrohling
reviewed
Jun 16, 2023
component/go.mod
Outdated
| @@ -35,6 +35,8 @@ require ( | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
this was added in the previous PR by crosslink removing other dependencies and leaving the new lines until i re-ran the tool
config/configauth/go.mod
Outdated
| go 1.19 | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
This go.mod looks strange now: perhaps add the direct dependencies first, the transitive after that, and the overrides at the bottom?
There was a problem hiding this comment.
I moved the replace, ptal
Linked issue: open-telemetry#7895 Signed-off-by: Alex Boten <aboten@lightstep.com>
ca0c241 to
6aafddb
Compare
codeboten
commented
Jun 16, 2023
Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7910 +/- ##
==========================================
+ Coverage 91.06% 91.12% +0.05%
==========================================
Files 298 298
Lines 14912 14912
==========================================
+ Hits 13580 13588 +8
+ Misses 1053 1047 -6
+ Partials 279 277 -2 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue #7895
Follow up to #7908