Mark connectors as stable #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d2b0323 to
638c74d
Compare
codeboten
reviewed
Apr 17, 2023
a74232e to
b32a027
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7539 +/- ##
=======================================
Coverage 91.18% 91.18%
=======================================
Files 296 296
Lines 14422 14422
=======================================
Hits 13151 13151
Misses 1006 1006
Partials 265 265 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Should be good to go now. |
bogdandrutu
reviewed
Apr 17, 2023
| @@ -19,6 +19,7 @@ import "go.opentelemetry.io/collector/featuregate" | |||
|
|
|||
| var ConnectorsFeatureGate = featuregate.GlobalRegistry().MustRegister( | |||
| "service.connectors", | |||
| featuregate.StageBeta, | |||
| featuregate.StageStable, | |||
There was a problem hiding this comment.
Add please the "FromVersion"
There was a problem hiding this comment.
Added, backdated to v0.71.0.
|
Can we close #2336 prior to merging this PR? |
b32a027 to
004dff3
Compare
|
@atoulme, done. |
dmitryax
approved these changes
Apr 18, 2023
codeboten
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the connectors codebase has proven to be very stable, as we haven't had to make any changes to support development of individual connectors. If there are no objections, I'd like to mark the gate stable ahead of the next release.