Skip to content

Commit

Permalink
Mark connectors as stable
Browse files Browse the repository at this point in the history
  • Loading branch information
djaglowski committed Apr 17, 2023
1 parent fe508cf commit b32a027
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 15 deletions.
16 changes: 16 additions & 0 deletions .chloggen/connectors-stable.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver)
component: connector

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Mark 'service.connectors' featuregate as stable

# One or more tracking issues or pull requests related to the change
issues: [2336]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
7 changes: 0 additions & 7 deletions otelcol/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,10 @@ import (
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"go.uber.org/zap/zapcore"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/config/configtelemetry"
"go.opentelemetry.io/collector/featuregate"
"go.opentelemetry.io/collector/otelcol/internal/sharedgate"
"go.opentelemetry.io/collector/service"
"go.opentelemetry.io/collector/service/telemetry"
)
Expand Down Expand Up @@ -256,10 +253,6 @@ func TestConfigValidate(t *testing.T) {
},
}

require.NoError(t, featuregate.GlobalRegistry().Set(sharedgate.ConnectorsFeatureGate.ID(), true))
defer func() {
require.NoError(t, featuregate.GlobalRegistry().Set(sharedgate.ConnectorsFeatureGate.ID(), false))
}()
for _, test := range testCases {
t.Run(test.name, func(t *testing.T) {
cfg := test.cfgFn()
Expand Down
5 changes: 3 additions & 2 deletions otelcol/internal/sharedgate/sharedgate.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import "go.opentelemetry.io/collector/featuregate"

var ConnectorsFeatureGate = featuregate.GlobalRegistry().MustRegister(
"service.connectors",
featuregate.StageBeta,
featuregate.StageStable,
featuregate.WithRegisterDescription("Enables 'connectors', a new type of component for transmitting signals between pipelines."),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector/issues/2336"))
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector/issues/2336"),
featuregate.WithRegisterToVersion("v0.78.0"))
6 changes: 0 additions & 6 deletions otelcol/otelcoltest/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import (
"github.com/stretchr/testify/require"

"go.opentelemetry.io/collector/component"
"go.opentelemetry.io/collector/featuregate"
"go.opentelemetry.io/collector/otelcol/internal/sharedgate"
"go.opentelemetry.io/collector/service"
)

Expand Down Expand Up @@ -76,10 +74,6 @@ func TestLoadConfigAndValidate(t *testing.T) {
factories, err := NopFactories()
assert.NoError(t, err)

require.NoError(t, featuregate.GlobalRegistry().Set(sharedgate.ConnectorsFeatureGate.ID(), true))
defer func() {
require.NoError(t, featuregate.GlobalRegistry().Set(sharedgate.ConnectorsFeatureGate.ID(), false))
}()
cfgValidate, errValidate := LoadConfigAndValidate(filepath.Join("testdata", "config.yaml"), factories)
require.NoError(t, errValidate)

Expand Down

0 comments on commit b32a027

Please sign in to comment.