Add connector factory #6611
Merged
Add connector factory #6611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a22fe87 to
41b2d26
Compare
Codecov ReportBase: 91.09% // Head: 91.06% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6611 +/- ##
==========================================
- Coverage 91.09% 91.06% -0.03%
==========================================
Files 243 244 +1
Lines 14105 14120 +15
==========================================
+ Hits 12849 12859 +10
- Misses 1006 1010 +4
- Partials 250 251 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
approved these changes
Nov 23, 2022
41b2d26 to
8be6bd2
Compare
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
jaronoff97
pushed a commit
to lightstep/opentelemetry-collector
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #6577
Respects intention of #6552 by defining the factory as part of the
connectorpackage rather thancomponent.