-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define new component type "connector" #6577
Define new component type "connector" #6577
Conversation
Codecov ReportBase: 91.07% // Head: 91.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6577 +/- ##
==========================================
- Coverage 91.07% 91.03% -0.05%
==========================================
Files 242 242
Lines 14054 14070 +16
==========================================
+ Hits 12800 12808 +8
- Misses 1004 1012 +8
Partials 250 250
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
6dbe756
to
75d30cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment skip changes to "Host" and "Factories" and follow guidance from #6578.
This way we have the interfaces also in a "not yet stable" package which will be the "/connector" package.
75d30cd
to
e5efc50
Compare
@bogdandrutu, I've followed #6552 as much as possible, stripped out factory code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase, and use newly added "settings" to remove duplicate code, see last merged PR.
a045390
to
d924044
Compare
@bogdandrutu, I've rebased and switched to |
This establishes the new component type without including anything specific about the design of connectors.
bb8f49f
to
e3e50d3
Compare
This establishes the new component type without including anything specific about the design of connectors.
This establishes the new component type without including anything specific about the design of connectors.
Looks like the addition of the connectors feature may have missed some needed changes in the |
@ringerc, please see #8721 (comment) for an explanation and proposed changes. |
This establishes the new component type without including anything specific about the design of connectors.
Subset of #6372