Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new component type "connector" #6577

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Nov 18, 2022

This establishes the new component type without including anything specific about the design of connectors.

Subset of #6372

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 91.07% // Head: 91.03% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (a045390) compared to base (d9b85d3).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head a045390 differs from pull request most recent head e3e50d3. Consider uploading reports for the commit e3e50d3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6577      +/-   ##
==========================================
- Coverage   91.07%   91.03%   -0.05%     
==========================================
  Files         242      242              
  Lines       14054    14070      +16     
==========================================
+ Hits        12800    12808       +8     
- Misses       1004     1012       +8     
  Partials      250      250              
Impacted Files Coverage Δ
component/component.go 62.22% <ø> (ø)
config/connector.go 0.00% <0.00%> (ø)
config/extension.go 66.66% <0.00%> (-33.34%) ⬇️
config/exporter.go 100.00% <0.00%> (ø)
config/receiver.go 100.00% <0.00%> (ø)
config/processor.go 100.00% <0.00%> (ø)
config/settings.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review November 18, 2022 16:15
@djaglowski djaglowski requested review from a team and jpkrohling November 18, 2022 16:15
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the moment skip changes to "Host" and "Factories" and follow guidance from #6578.

This way we have the interfaces also in a "not yet stable" package which will be the "/connector" package.

config/connector.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member Author

@bogdandrutu, I've followed #6552 as much as possible, stripped out factory code.

connector/connector.go Outdated Show resolved Hide resolved
config/connector.go Outdated Show resolved Hide resolved
config/connector.go Outdated Show resolved Hide resolved
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, and use newly added "settings" to remove duplicate code, see last merged PR.

@djaglowski
Copy link
Member Author

@bogdandrutu, I've rebased and switched to settings

config/connector.go Outdated Show resolved Hide resolved
config/connector.go Outdated Show resolved Hide resolved
config/connector.go Outdated Show resolved Hide resolved
This establishes the new component type without including anything
specific about the design of connectors.
@bogdandrutu bogdandrutu merged commit c914964 into open-telemetry:main Nov 23, 2022
@djaglowski djaglowski deleted the connector-component branch November 23, 2022 12:19
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
This establishes the new component type without including anything
specific about the design of connectors.
jaronoff97 pushed a commit to lightstep/opentelemetry-collector that referenced this pull request Dec 14, 2022
This establishes the new component type without including anything
specific about the design of connectors.
@ringerc
Copy link

ringerc commented Nov 13, 2023

Looks like the addition of the connectors feature may have missed some needed changes in the validate subcommand. See #8866

@djaglowski
Copy link
Member Author

@ringerc, please see #8721 (comment) for an explanation and proposed changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants