[configtelemetry] Update strings returned by Level.[String|MarshalText]
#6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81df9f3 to
906b7b4
Compare
Level.[String|Marshal]Level.[String|MarshalText]
bogdandrutu
reviewed
Nov 12, 2022
…xt]` - All returned strings are capitalized. - "" is returned for integers that are out of Level enum range. - It also affects `Level.MarshalText` output, but it's not a problem because `UnmarshalText` method accepts strings in all cases, e.g. "normal", "Normal" and "NORMAL".
906b7b4 to
0c98c3e
Compare
Codecov ReportBase: 91.33% // Head: 91.33% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6533 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 242 242
Lines 13888 13888
=======================================
Hits 12684 12684
Misses 959 959
Partials 245 245
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level.MarshalTextoutput, but it's not a problem becauseUnmarshalTextmethod accepts strings in all cases, e.g. "normal", "Normal" and "NORMAL".Updates #6490