-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String representation of component.StabilityLevel
and configtelemetry.Level
is inconsistent with other types
#6490
Comments
I think I like the "Capitalized" version more. |
I also prefer capitalization. It aligns with my expectation that Capitalized Terms are well-defined somewhere in the domain and may carry denotations beyond what might otherwise be considered as their plain meaning. |
@dmitryax for configs I think we should allow any capitalization? I think it is fine if in the config file (like **Update:" this may be a separate issue to discuss, but is related at least with |
Yes, that's how it's currently done in |
Capitalized is fine with me. |
Sounds good! I'll submit a PR to capitalize |
For
|
@dmitryax is this completed? Is there still something left to do here? |
It looks like the original issue is completed. Bogdan mentions we could look at renaming |
I've captured the configcompression piece in its own issue. Closing this as completed. |
String
methods of all types inpdata
module along withservice.State
return capitalized strings, for example:pmetric.AggregationTemporality.String()
: "Unspecified", "Delta" or "Cumulative"service.State.String()
: "Starting", "Running", "Closing", etc.But
component.StabilityLevel
andconfigtelemetry.Level
return lowercase strings:configtelemetry.Level.String()
: "none", "basic", "normal" or"detailed"Should we align the to the same Capitalized format?
Or there is still a chance to make all other strings lowercase if we think that's a better option.
cc @bogdandrutu @codeboten @Aneurysm9
The text was updated successfully, but these errors were encountered: