State set to closing when Collector Run encounters startup failure #4974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4974 +/- ##
==========================================
- Coverage 90.95% 90.94% -0.01%
==========================================
Files 182 182
Lines 10672 10674 +2
==========================================
+ Hits 9707 9708 +1
- Misses 748 749 +1
Partials 217 217
Continue to review full report at Codecov.
|
acc5fa5 to
fa6d8a4
Compare
bogdandrutu
approved these changes
Mar 13, 2022
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
fa6d8a4 to
e71e4b2
Compare
Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
bogdandrutu
approved these changes
Mar 14, 2022
Nicholaswang
pushed a commit
to Nicholaswang/opentelemetry-collector
that referenced
this pull request
Jun 7, 2022
…pen-telemetry#4974) * When Run fails due to a startup issue it will set the state to closed Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com> * Fixed changelog Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes: #4826
If the
Runexited due to an error during startup the state would stay asStartingchanged this to be set toClosedwhen any startup error occurs.There might need to be a larger discussion on if
Closedis the correct state or if we should introduce aFailedorErrorstate that would be more appropriate here.?Link to tracking Issue: #4826
Testing: Added unit tests to valid state change