State set to closing when Collector Run encounters startup failure (#…

…4974)

* When Run fails due to a startup issue it will set the state to closed

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

* Fixed changelog

Signed-off-by: Corbin Phelps <corbin.phelps@bluemedora.com>

CHANGELOG.md

@@ -17,6 +17,7 @@
 
 - Collector `Run` will now exit when a context cancels (#4954)
 - Add missing droppedAttributesCount to pdata generated resource (#4979)
+- Collector `Run` will now set state to `Closed` if startup fails (#4974)
 
 ## v0.46.0 Beta
 

service/collector.go

@@ -239,10 +239,12 @@ func (col *Collector) Run(ctx context.Context) error {
 	col.asyncErrorChannel = make(chan error)
 
 	if err := col.setupConfigurationComponents(ctx); err != nil {
+		col.setCollectorState(Closed)
 		return err
 	}
 
 	if err := collectorTelemetry.init(col); err != nil {
+		col.setCollectorState(Closed)
 		return err
 	}
 

service/collector_test.go

@@ -212,6 +212,31 @@ func TestCollector_ShutdownBeforeRun(t *testing.T) {
 	assert.Equal(t, Closed, col.GetState())
 }
 
+// TestCollector_ClosedStateOnStartUpError tests the collector changes it's state to Closed when a startup error occurs
+func TestCollector_ClosedStateOnStartUpError(t *testing.T) {
+	preservedAppTelemetry := collectorTelemetry
+	collectorTelemetry = &colTelemetry{}
+	defer func() { collectorTelemetry = preservedAppTelemetry }()
+
+	factories, err := testcomponents.NewDefaultFactories()
+	require.NoError(t, err)
+
+	// Load a bad config causing startup to fail
+	set := CollectorSettings{
+		BuildInfo:      component.NewDefaultBuildInfo(),
+		Factories:      factories,
+		ConfigProvider: MustNewDefaultConfigProvider([]string{filepath.Join("testdata", "otelcol-invalid.yaml")}, nil),
+	}
+	col, err := New(set)
+	require.NoError(t, err)
+
+	// Expect run to error
+	require.Error(t, col.Run(context.Background()))
+
+	// Expect state to be closed
+	assert.Equal(t, Closed, col.GetState())
+}
+
 type mockColTelemetry struct{}
 
 func (tel *mockColTelemetry) init(*Collector) error {