Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otlp receiver: Fix HTTP server config source and legacy port mutation #4631

Merged

Conversation

rmfitzpatrick
Copy link
Contributor

Description:
Fixing a bug - When #4519 was added it revealed that default http endpoint usage results in the otlp receiver modifying its config and that the http server starting logic disregarded the config parameter.

Reported via signalfx/splunk-otel-collector#1064

Testing:
Added unit test

Documentation:
Updated changelog, but none needed otherwise.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #4631 (7989763) into main (60e0cf6) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4631      +/-   ##
==========================================
+ Coverage   90.36%   90.44%   +0.07%     
==========================================
  Files         181      181              
  Lines       10598    10598              
==========================================
+ Hits         9577     9585       +8     
+ Misses        797      789       -8     
  Partials      224      224              
Impacted Files Coverage Δ
receiver/otlpreceiver/otlp.go 81.33% <100.00%> (+5.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e0cf6...7989763. Read the comment docs.

@bogdandrutu
Copy link
Member

@rmfitzpatrick why not fixing #4565?

@rmfitzpatrick
Copy link
Contributor Author

@rmfitzpatrick why not fixing #4565?

Because it sounds like they may be removed in total in the future and I opted to fix a bug in the meantime: #4565 (comment)

@bogdandrutu
Copy link
Member

I think the decision on that issue is that "the future" is now :)

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it!

It looks good to me.

@bogdandrutu I would vote for merging it before cutting the new release this week, and we can disable the legacy endpoint after that.

CHANGELOG.md Outdated Show resolved Hide resolved
@rmfitzpatrick rmfitzpatrick force-pushed the legacyhttpportcfgclone branch from b6471fc to 7989763 Compare January 5, 2022 15:53
@bogdandrutu bogdandrutu merged commit f13a011 into open-telemetry:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants