Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a way to disable the legacy HTTP endpoint #4565

Closed
rgl opened this issue Dec 17, 2021 · 2 comments · Fixed by #4916
Closed

Have a way to disable the legacy HTTP endpoint #4565

rgl opened this issue Dec 17, 2021 · 2 comments · Fixed by #4916
Labels
bug Something isn't working

Comments

@rgl
Copy link

rgl commented Dec 17, 2021

Describe the bug

There is no way to disable the legacy HTTP endpoint.

This behavior seems to be hardcoded without a way to disable.

Steps to reproduce

When using this library from Tempo, I've explicitly set the HTTP endpoint as:

distributor:
  receivers:
    # see https://github.com/grafana/tempo/blob/v1.2.1/modules/distributor/config.go#L33
    # see https://github.com/open-telemetry/opentelemetry-collector/tree/main/receiver/otlpreceiver
    otlp:
      protocols:
        http:
          endpoint: 0.0.0.0:4318

What did you expect to see?

Only port 4318 listening.

What did you see instead?

It also opens the legacy HTTP listener at port 55681.

What version did you use?

I'm using it tru Tempo 1.2.1. I think its using v0.21.0:

Also note that the latest collector version (v0.41.0) also uses the same code, so I guess it also has the same behavior.

What config did you use?

See the description.

Environment

OS: Ubuntu 20.04
Compiler(if manually compiled): N/A.

Additional context

Originally asked for help at grafana/tempo#1181

@rgl rgl added the bug Something isn't working label Dec 17, 2021
@jpkrohling
Copy link
Member

Interesting, I thought we enabled it only when no values were explicitly provided. I think it might be time to remove this anyway... Thoughts from other approvers and maintainers?

cc @open-telemetry/collector-maintainers , @open-telemetry/collector-approvers

@tigrannajaryan
Copy link
Member

Let's remove legacy ports completely. I think we kept it in grace period for long enough.

bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 23, 2022
Fixes: open-telemetry#4565

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Feb 23, 2022
Fixes: open-telemetry#4565

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
codeboten pushed a commit that referenced this issue Feb 24, 2022
Fixes: #4565

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants