Tidy up consumer/consumererror package.
#2768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2768 +/- ##
==========================================
- Coverage 91.72% 91.72% -0.01%
==========================================
Files 292 292
Lines 15538 15555 +17
==========================================
+ Hits 14253 14268 +15
- Misses 880 882 +2
Partials 405 405
Continue to review full report at Codecov.
|
bogdandrutu
reviewed
Mar 23, 2021
bogdandrutu
reviewed
Mar 23, 2021
bogdandrutu
reviewed
Mar 23, 2021
* Updated docblocks for grammar and consistency * Added `IsPartial()` predicate to match `IsPermanent()` * Ensured tests for `PartialError` test the public interface Remove `PartialError` and replace with individual signal error types Refactor consumererror signal extraction to simplify exporterhelper request interface
This moves the accessors for signal data to methods on the individual error types and provides As<Signal>() package functions that behave as targeted versions of the errors.As() function.
76ccbe6 to
2a2aa5e
Compare
bogdandrutu
approved these changes
Mar 23, 2021
…tor into consumererror_tidy
This was referenced Mar 23, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PartialErrorand replace with individual signal error typesCombineErrorstoCombineLink to tracking Issue: #2476
Testing: Unit test suite was executed, tests were added for new and modified functions to ensure coverage. I observed an inexplicable test failure on OS X in a log exporter method where only a function invocation was changed to a new name with the same function body. It appears to be related to uber-go/zap#370 and is not reproducible on Linux via Docker.