Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate SinkExporter, add SinkConsumer #1973

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

bogdandrutu
Copy link
Member

Depends on #1972

@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #1973 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1973      +/-   ##
==========================================
+ Coverage   91.46%   91.49%   +0.03%     
==========================================
  Files         281      282       +1     
  Lines       16559    16619      +60     
==========================================
+ Hits        15145    15205      +60     
  Misses        978      978              
  Partials      436      436              
Impacted Files Coverage Δ
exporter/exportertest/sink_exporter.go 100.00% <ø> (ø)
consumer/consumertest/sink.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c8768...4a0350f. Read the comment docs.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@bogdandrutu bogdandrutu requested a review from a team October 20, 2020 00:58
@bogdandrutu bogdandrutu merged commit ba96d13 into open-telemetry:master Oct 20, 2020
@bogdandrutu bogdandrutu deleted the sinktest branch October 20, 2020 01:26
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* fix jaeger exporter test panic with close closed channel

* add change to CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1973)

Bumps [boto3](https://github.com/boto/boto3) from 1.24.64 to 1.24.72.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.24.64...1.24.72)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants