Deprecate NopExporter, add NopConsumer #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
commented
Oct 18, 2020
ba5106a to
74ded3f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1972 +/- ##
==========================================
- Coverage 91.46% 91.45% -0.02%
==========================================
Files 280 281 +1
Lines 16547 16550 +3
==========================================
+ Hits 15134 15135 +1
- Misses 977 979 +2
Partials 436 436
Continue to review full report at Codecov.
|
tigrannajaryan
approved these changes
Oct 19, 2020
In few situations people complained about not having a nop consumer, because of confusion that it was implemented as Exporter, even if only used as Consumer. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
74ded3f to
bc5956d
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
…/otlp/otlptrace (open-telemetry#1972) * Bump github.com/cenkalti/backoff/v4 in /exporters/otlp/otlptrace Bumps [github.com/cenkalti/backoff/v4](https://github.com/cenkalti/backoff) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/cenkalti/backoff/releases) - [Commits](cenkalti/backoff@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: github.com/cenkalti/backoff/v4 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Auto-fix go.sum changes in dependent modules Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…n-telemetry#1972) * fix templating and add tests for watch file and template files * add integration test for templated configs * rename test file * Update tests/general/include_config_source_test.go Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com> * call cancel in subprocess shutdown Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In few situations people complained about not having a nop consumer,
because of confusion that it was implemented as Exporter, even if only used as Consumer.