Handle translation of OC span.kind attribute for client/server #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Brown <gary@brownuk.com>
Codecov Report
@@ Coverage Diff @@
## master #1636 +/- ##
==========================================
- Coverage 91.90% 91.89% -0.01%
==========================================
Files 254 254
Lines 17309 17313 +4
==========================================
+ Hits 15907 15909 +2
- Misses 1006 1007 +1
- Partials 396 397 +1
Continue to review full report at Codecov.
|
|
Test failures seem unrelated - e.g. probabilistic sampler processor. |
bogdandrutu
approved these changes
Sep 11, 2020
|
@bogdandrutu @objectiser Seems like this merge has broken the main branch: https://github.com/open-telemetry/opentelemetry-collector/commits/master |
|
Did this branch pass the CI build? master is now broken. |
|
Reverted in #1775 since this broke the master build. |
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
This patch removes `ApplyConfig` method and `Config` struct from `go.opentelemetry.io/otel/sdk/trace` package. To ensure valid config for TracerProvider, it adds `ensureValidTracerProviderConfig` private function. Jaeger and Zipkin have been used the `Config` directly across package boundaries. Since `Config` is removed, they can't use it. This change, thus, replaces `WithSDK` with `WithSDKOptions`. Resolves open-telemetry#1636, open-telemetry#1705.
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
This is a minor fix of a typo in the dependencies documentation.`@io_opentelemetry_cpp/api:with_abseil` is not a valid Bazel target name, it should instead be @io_opentelemetry_cpp//api:with_abseil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gary Brown gary@brownuk.com
Description:
Currently OpenCensus seems to allow span kind to be reported via a field (only
clientandservervalues) or an attribute (onlyconsumerandproducervalues).This PR extends support for handling
clientandservervalues via the attribute. This additional flexibility will enable Envoy (using the current C++ opencensus client with no span kind field support) to report the span kind value.Link to tracking Issue:
Fixes #1608
Testing:
Unit test.
Documentation: