Revert "Handle translation of OC span.kind attribute for client/server (

#1636)" (#1775) This reverts commit 7071a9d. I am reverting the commit since it broke the master build.
open-telemetry · Sep 14, 2020 · 319c6da · 319c6da
1 parent b7c9d92
commit 319c6da
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/translator/internaldata/oc_to_traces.go b/translator/internaldata/oc_to_traces.go
@@ -248,10 +248,6 @@ func ocSpanKindToInternal(ocKind octrace.Span_SpanKind, ocAttrs *octrace.Span_At
 				if ok && strVal != nil {
 					var otlpKind pdata.SpanKind
 					switch tracetranslator.OpenTracingSpanKind(strVal.StringValue.GetValue()) {
-					case tracetranslator.OpenTracingSpanKindClient:
-						otlpKind = pdata.SpanKindCLIENT
-					case tracetranslator.OpenTracingSpanKindServer:
-						otlpKind = pdata.SpanKindSERVER
 					case tracetranslator.OpenTracingSpanKindConsumer:
 						otlpKind = pdata.SpanKindCONSUMER
 					case tracetranslator.OpenTracingSpanKindProducer:

diff --git a/translator/internaldata/oc_to_traces_test.go b/translator/internaldata/oc_to_traces_test.go
@@ -161,26 +161,6 @@ func TestOcSpanKindToInternal(t *testing.T) {
 			},
 			otlpKind: otlptrace.Span_SPAN_KIND_PRODUCER,
 		},
-		{
-			ocKind: octrace.Span_SPAN_KIND_UNSPECIFIED,
-			ocAttrs: &octrace.Span_Attributes{
-				AttributeMap: map[string]*octrace.AttributeValue{
-					"span.kind": {Value: &octrace.AttributeValue_StringValue{
-						StringValue: &octrace.TruncatableString{Value: "client"}}},
-				},
-			},
-			otlpKind: otlptrace.Span_CLIENT,
-		},
-		{
-			ocKind: octrace.Span_SPAN_KIND_UNSPECIFIED,
-			ocAttrs: &octrace.Span_Attributes{
-				AttributeMap: map[string]*octrace.AttributeValue{
-					"span.kind": {Value: &octrace.AttributeValue_StringValue{
-						StringValue: &octrace.TruncatableString{Value: "server"}}},
-				},
-			},
-			otlpKind: otlptrace.Span_SERVER,
-		},
 		{
 			ocKind: octrace.Span_SPAN_KIND_UNSPECIFIED,
 			ocAttrs: &octrace.Span_Attributes{