Fix OTLP http receiver to correctly set Retry-After #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12367 +/- ##
==========================================
+ Coverage 91.51% 91.54% +0.02%
==========================================
Files 467 467
Lines 25623 25623
==========================================
+ Hits 23450 23456 +6
+ Misses 1774 1768 -6
Partials 399 399 ☔ View full report in Codecov by Sentry. |
b2612a9 to
95cabe8
Compare
95cabe8 to
b3dd063
Compare
b3dd063 to
0b41fad
Compare
bogdandrutu
commented
Feb 13, 2025
|
|
||
| if !shouldRetry(st.Code(), retryInfo) { | ||
| // It is not a retryable error, we should not retry. | ||
| return consumererror.NewPermanent(err) | ||
| } | ||
|
|
||
| // Check if server returned throttling information. | ||
| throttleDuration := getThrottleDuration(retryInfo) | ||
| throttleDuration := retryInfo.GetRetryDelay().AsDuration() | ||
| if throttleDuration != 0 { |
There was a problem hiding this comment.
Will fix in a followup to always include the throttle information if present and not retryable.
88074f9 to
bdc5222
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bdc5222 to
dafd402
Compare
dmitryax
approved these changes
Feb 14, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 14, 2025
2dc95de
56 of 57 checks passed
|
@bogdandrutu Since this PR creates a new module, can you file a follow up PR to do step 5 from this list:
Otherwise we cannot run |
|
Filed #12404 for ^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.