[chore] Use pseudo-versions to require componenttest
#11668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11668 +/- ##
=======================================
Coverage 91.58% 91.59%
=======================================
Files 440 440
Lines 23765 23755 -10
=======================================
- Hits 21766 21759 -7
+ Misses 1627 1625 -2
+ Partials 372 371 -1 ☔ View full report in Codecov by Sentry. |
componenttestcomponenttest
songy23
approved these changes
Nov 13, 2024
evan-bradley
approved these changes
Nov 13, 2024
bogdandrutu
approved these changes
Nov 13, 2024
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 15, 2024
#### Description Now that the PR to split `extensiontest` into its own module (#11629) has landed, we can import the new module in an externally-resolvable way using the pseudo-version corresponding to the merge commit, similar to what I did for `componenttest` (#11668). After the next release (0.114.0), we will be able to use that version number instead for internal imports.
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…y#11668) #### Description My previous PR (open-telemetry#11615) which made `component/componenttest` into its own module tagged it as `v0.113.0` in the requirements of other modules. This works locally because of the `replace` statements, but since the module was never _actually_ released as v0.113.0, this causes issues in contrib (cf. open-telemetry#11509 and open-telemetry#11511). This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable. #### Link to tracking issue None. #### Testing I removed the `replace` statements for `componenttest`, ran `make gotidy`, which allowed `make otelcorecol` to run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will try `make update-otel [...]` on contrib with the appropriate commit ID to check that the issue is resolved.
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…y#11677) #### Description Now that the PR to split `extensiontest` into its own module (open-telemetry#11629) has landed, we can import the new module in an externally-resolvable way using the pseudo-version corresponding to the merge commit, similar to what I did for `componenttest` (open-telemetry#11668). After the next release (0.114.0), we will be able to use that version number instead for internal imports.
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 21, 2024
#### Description Now that #11705 has been merged, splitting the `extension/auth/authtest` package into a separate module, this PR updates imports of the new module to an externally resolvable pseudo-version based on the merge commit (f2e05b5). (See #11668 for context on why this two-step process is necessary.) #### Link to tracking issue Resolves #11465
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…y#11668) #### Description My previous PR (open-telemetry#11615) which made `component/componenttest` into its own module tagged it as `v0.113.0` in the requirements of other modules. This works locally because of the `replace` statements, but since the module was never _actually_ released as v0.113.0, this causes issues in contrib (cf. open-telemetry#11509 and open-telemetry#11511). This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable. #### Link to tracking issue None. #### Testing I removed the `replace` statements for `componenttest`, ran `make gotidy`, which allowed `make otelcorecol` to run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will try `make update-otel [...]` on contrib with the appropriate commit ID to check that the issue is resolved.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…y#11677) #### Description Now that the PR to split `extensiontest` into its own module (open-telemetry#11629) has landed, we can import the new module in an externally-resolvable way using the pseudo-version corresponding to the merge commit, similar to what I did for `componenttest` (open-telemetry#11668). After the next release (0.114.0), we will be able to use that version number instead for internal imports.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
#### Description Now that open-telemetry#11705 has been merged, splitting the `extension/auth/authtest` package into a separate module, this PR updates imports of the new module to an externally resolvable pseudo-version based on the merge commit (f2e05b5). (See open-telemetry#11668 for context on why this two-step process is necessary.) #### Link to tracking issue Resolves open-telemetry#11465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My previous PR (#11615) which made
component/componenttestinto its own module tagged it asv0.113.0in the requirements of other modules. This works locally because of thereplacestatements, but since the module was never actually released as v0.113.0, this causes issues in contrib (cf. #11509 and #11511).This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable.
Link to tracking issue
None.
Testing
I removed the
replacestatements forcomponenttest, ranmake gotidy, which allowedmake otelcorecolto run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will trymake update-otel [...]on contrib with the appropriate commit ID to check that the issue is resolved.