Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make componenttest into its own module #11615

Merged

Conversation

jade-guiton-dd
Copy link
Contributor

Description

Turn the go.opentelemetry.io/collector/component/componenttest package into its own module

Link to tracking issue

Resolves #11464

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.52%. Comparing base (e76145a) to head (4d56fc4).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11615   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files         441      441           
  Lines       23914    23914           
=======================================
  Hits        21888    21888           
  Misses       1650     1650           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jade-guiton-dd jade-guiton-dd marked this pull request as ready for review November 6, 2024 16:03
@jade-guiton-dd jade-guiton-dd requested a review from a team as a code owner November 6, 2024 16:03
@songy23 songy23 requested a review from mx-psi November 6, 2024 23:18
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi requested a review from TylerHelmuth November 7, 2024 16:26
@mx-psi mx-psi merged commit f0fb20d into open-telemetry:main Nov 7, 2024
66 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 7, 2024
bogdandrutu pushed a commit that referenced this pull request Nov 13, 2024
#### Description

My previous PR (#11615) which made `component/componenttest` into its
own module tagged it as `v0.113.0` in the requirements of other modules.
This works locally because of the `replace` statements, but since the
module was never _actually_ released as v0.113.0, this causes issues in
contrib (cf. #11509 and #11511).

This PR updates those requirements to use a pseudo-version pointing at a
recent commit on main, which should be properly externally resolvable.

#### Link to tracking issue
None.

#### Testing
I removed the `replace` statements for `componenttest`, ran `make
gotidy`, which allowed `make otelcorecol` to run successfully. Not sure
if this is a thorough enough test however. Once this PR is merged, I
will try `make update-otel [...]` on contrib with the appropriate commit
ID to check that the issue is resolved.
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
#### Description

Turn the `go.opentelemetry.io/collector/component/componenttest` package
into its own module

#### Link to tracking issue
Resolves open-telemetry#11464
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…y#11668)

#### Description

My previous PR (open-telemetry#11615) which made `component/componenttest` into its
own module tagged it as `v0.113.0` in the requirements of other modules.
This works locally because of the `replace` statements, but since the
module was never _actually_ released as v0.113.0, this causes issues in
contrib (cf. open-telemetry#11509 and open-telemetry#11511).

This PR updates those requirements to use a pseudo-version pointing at a
recent commit on main, which should be properly externally resolvable.

#### Link to tracking issue
None.

#### Testing
I removed the `replace` statements for `componenttest`, ran `make
gotidy`, which allowed `make otelcorecol` to run successfully. Not sure
if this is a thorough enough test however. Once this PR is merged, I
will try `make update-otel [...]` on contrib with the appropriate commit
ID to check that the issue is resolved.
@jade-guiton-dd jade-guiton-dd deleted the 11464-componenttest-module branch November 27, 2024 13:37
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
#### Description

Turn the `go.opentelemetry.io/collector/component/componenttest` package
into its own module

#### Link to tracking issue
Resolves open-telemetry#11464
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…y#11668)

#### Description

My previous PR (open-telemetry#11615) which made `component/componenttest` into its
own module tagged it as `v0.113.0` in the requirements of other modules.
This works locally because of the `replace` statements, but since the
module was never _actually_ released as v0.113.0, this causes issues in
contrib (cf. open-telemetry#11509 and open-telemetry#11511).

This PR updates those requirements to use a pseudo-version pointing at a
recent commit on main, which should be properly externally resolvable.

#### Link to tracking issue
None.

#### Testing
I removed the `replace` statements for `componenttest`, ran `make
gotidy`, which allowed `make otelcorecol` to run successfully. Not sure
if this is a thorough enough test however. Once this PR is merged, I
will try `make update-otel [...]` on contrib with the appropriate commit
ID to check that the issue is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make componenttest into its own module
4 participants