-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make componenttest
into its own module
#11615
Merged
mx-psi
merged 1 commit into
open-telemetry:main
from
jade-guiton-dd:11464-componenttest-module
Nov 7, 2024
Merged
Make componenttest
into its own module
#11615
mx-psi
merged 1 commit into
open-telemetry:main
from
jade-guiton-dd:11464-componenttest-module
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11615 +/- ##
=======================================
Coverage 91.52% 91.52%
=======================================
Files 441 441
Lines 23914 23914
=======================================
Hits 21888 21888
Misses 1650 1650
Partials 376 376 ☔ View full report in Codecov by Sentry. |
songy23
approved these changes
Nov 6, 2024
mx-psi
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TylerHelmuth
approved these changes
Nov 7, 2024
bogdandrutu
pushed a commit
that referenced
this pull request
Nov 13, 2024
#### Description My previous PR (#11615) which made `component/componenttest` into its own module tagged it as `v0.113.0` in the requirements of other modules. This works locally because of the `replace` statements, but since the module was never _actually_ released as v0.113.0, this causes issues in contrib (cf. #11509 and #11511). This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable. #### Link to tracking issue None. #### Testing I removed the `replace` statements for `componenttest`, ran `make gotidy`, which allowed `make otelcorecol` to run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will try `make update-otel [...]` on contrib with the appropriate commit ID to check that the issue is resolved.
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
#### Description Turn the `go.opentelemetry.io/collector/component/componenttest` package into its own module #### Link to tracking issue Resolves open-telemetry#11464
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector
that referenced
this pull request
Nov 21, 2024
…y#11668) #### Description My previous PR (open-telemetry#11615) which made `component/componenttest` into its own module tagged it as `v0.113.0` in the requirements of other modules. This works locally because of the `replace` statements, but since the module was never _actually_ released as v0.113.0, this causes issues in contrib (cf. open-telemetry#11509 and open-telemetry#11511). This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable. #### Link to tracking issue None. #### Testing I removed the `replace` statements for `componenttest`, ran `make gotidy`, which allowed `make otelcorecol` to run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will try `make update-otel [...]` on contrib with the appropriate commit ID to check that the issue is resolved.
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
#### Description Turn the `go.opentelemetry.io/collector/component/componenttest` package into its own module #### Link to tracking issue Resolves open-telemetry#11464
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
…y#11668) #### Description My previous PR (open-telemetry#11615) which made `component/componenttest` into its own module tagged it as `v0.113.0` in the requirements of other modules. This works locally because of the `replace` statements, but since the module was never _actually_ released as v0.113.0, this causes issues in contrib (cf. open-telemetry#11509 and open-telemetry#11511). This PR updates those requirements to use a pseudo-version pointing at a recent commit on main, which should be properly externally resolvable. #### Link to tracking issue None. #### Testing I removed the `replace` statements for `componenttest`, ran `make gotidy`, which allowed `make otelcorecol` to run successfully. Not sure if this is a thorough enough test however. Once this PR is merged, I will try `make update-otel [...]` on contrib with the appropriate commit ID to check that the issue is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn the
go.opentelemetry.io/collector/component/componenttest
package into its own moduleLink to tracking issue
Resolves #11464