Fix otlphttpexporter parsing logic for Retry-After #12366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d21af7 to
b129cc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12366 +/- ##
==========================================
+ Coverage 91.42% 91.49% +0.06%
==========================================
Files 467 466 -1
Lines 25609 25616 +7
==========================================
+ Hits 23414 23438 +24
+ Misses 1789 1774 -15
+ Partials 406 404 -2 ☔ View full report in Codecov by Sentry. |
b129cc6 to
c1f342a
Compare
dmitryax
reviewed
Feb 12, 2025
dmitryax
reviewed
Feb 12, 2025
09be25f to
77bb67a
Compare
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
77bb67a to
330bf11
Compare
dmitryax
approved these changes
Feb 12, 2025
| if date, err := time.Parse(time.RFC1123, values[0]); err == nil { | ||
| return exporterhelper.NewThrottleRetry(formattedErr, time.Until(date)) | ||
| } | ||
| return formattedErr |
There was a problem hiding this comment.
This line must be redundant then
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement to not create a throttled error when delay is 0, same behavior.