Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New file receiver #7840

Merged
merged 22 commits into from
Jul 20, 2022
Merged

New file receiver #7840

merged 22 commits into from
Jul 20, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 11, 2022

Description:
This is an experimental new component that allows to read JSON serialized otel data from files.
The data can be read as logs, traces and metrics.
This PR was first opened as #6712 and was closed as it went stale.

Link to tracking Issue:
There is no issue tracking this work, this is mostly to support the work happening in open-telemetry/opentelemetry-specification#2235

Testing:
Unit tests.

Documentation:
Receiver README.

@atoulme atoulme force-pushed the new_file_receiver branch from df42cb0 to beff1f9 Compare March 8, 2022 00:49
@atoulme atoulme marked this pull request as ready for review March 8, 2022 00:49
@atoulme atoulme requested review from a team and dashpole March 8, 2022 00:49
receiver/filereceiver/README.md Outdated Show resolved Hide resolved
receiver/filereceiver/doc.go Outdated Show resolved Hide resolved
receiver/filereceiver/file.go Outdated Show resolved Hide resolved
receiver/filereceiver/file_test.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/watcher.go Outdated Show resolved Hide resolved
receiver/filereceiver/README.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@oliora
Copy link

oliora commented May 3, 2022

Is this PR abandoned? (No push, just asking)

@atoulme
Copy link
Contributor Author

atoulme commented May 4, 2022

No, just busy elsewhere. I can work out the conflicts.

@atoulme atoulme force-pushed the new_file_receiver branch from c21714a to 94c1b9a Compare May 4, 2022 00:27
@github-actions github-actions bot removed the Stale label May 8, 2022
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label May 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@mx-psi
Copy link
Member

mx-psi commented Jun 16, 2022

Should this be reopened?

@djaglowski
Copy link
Member

Although there will be some followup work necessary, #11076 isolates the file tracking and reading logic from the filelog receiver. This should become usable by this receiver in the near future.

@atoulme
Copy link
Contributor Author

atoulme commented Jun 21, 2022

I see it's now merged, so I can rebase this and get to work.

@atoulme atoulme force-pushed the new_file_receiver branch from cc8b67c to 92a0825 Compare July 16, 2022 16:04
@atoulme atoulme force-pushed the new_file_receiver branch from bf90316 to 81addce Compare July 16, 2022 16:40
@atoulme atoulme force-pushed the new_file_receiver branch from 81addce to d259526 Compare July 16, 2022 16:44
@atoulme
Copy link
Contributor Author

atoulme commented Jul 19, 2022

@djaglowski would you have time to go over it?

@djaglowski
Copy link
Member

This looks good to me. I've created #12603 to capture the extraneous errors when consuming multi-signal files.

Thanks for the contribution @atoulme.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit (it affects the public API, so it's better to handle it now)

receiver/otlpjsonfilereceiver/file.go Outdated Show resolved Hide resolved
@djaglowski djaglowski merged commit 55831bc into open-telemetry:main Jul 20, 2022
ZahidMirza95 pushed a commit to ZahidMirza95/opentelemetry-collector-contrib that referenced this pull request Jun 21, 2023
…emetry#7840)

* always pass a fanoutconsumer to connector factory functions

* add changelog entry

* start with false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants