-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/stanza] Extract file reading #11076
[pkg/stanza] Extract file reading #11076
Conversation
@djaglowski do all the file additions actually need reviewed or are they just being moved into this repo for the first time from logs-collection? |
@TylerHelmuth, the files are moved & slightly modified from their previous location in Perhaps @jsirianni could give this a once over? |
There are some minor memory utilization improvements here. This is somewhat expected because
This branch:
|
Running great for me 👍 |
cfa3d1e
to
b9de38e
Compare
@TylerHelmuth, do you mind taking another look at this, now that #11119 and #11124 are merged? |
This is a major step towards #10286.
I expect to follow this up with some cleanup PRs, but wanted to leave as much as possible in place so as not to further bloat an already huge PR.
[]byte
and leave decoding to the caller, or it should manage all decoding. Currently, this is somewhat awkwardly split across the interface. This would be a good topic to address in a followup PR.