-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASAP Client Authentication Extension #6627
ASAP Client Authentication Extension #6627
Conversation
@jpkrohling I have addressed your comments from the old PR:
You also asked
I don't know of a page that exactly outlines what you're asking, but I can explain some key differences here. Some differences:
Sorry about the old PR getting corrupted! Let me know if there's anything else I can do to improve the PR 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A small comment about the name of the comment and the data type for TTL. Nothing serious, and can be merged as it is if you don't think those changes are desired.
* asapauthextension + added to versions.yaml * address jpkrohling comments * reorder in correct alphabetical * Asap -> ASAP name change * update cfg to receive time.Duration directly, and reflect in tests and docs * appease linter
* asapauthextension + added to versions.yaml * address jpkrohling comments * reorder in correct alphabetical * Asap -> ASAP name change * update cfg to receive time.Duration directly, and reflect in tests and docs * appease linter
* asapauthextension + added to versions.yaml * address jpkrohling comments * reorder in correct alphabetical * Asap -> ASAP name change * update cfg to receive time.Duration directly, and reflect in tests and docs * appease linter
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com> Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
I have raised this PR as my branch was messed up in #6233 and needed to start on a fresh one
Description:
Adding an extension which allows the collector to authenticate outgoing requests with ASAP (Atlassian Service Authentication Protocol).
It works by implementing
ClientAuthenticator
and setting the authorization header as the encoded JWT. It uses the go-asap library to achieve much of its functionality.Link to tracking Issue:
#5930
Testing:
We mock key server and a base RoundTripper to achieve validation on signature and fields on the JWT. Configuration and factory are also tested. There are yaml files for good and bad config (one good, multiple bad configurations).
Additionally, at Atlassian we have been using ASAP in the collector for a long time already.
Documentation:
README.md gives a sample configuration and brief description. Those familiar with ASAP should have little trouble setting it up
Additionally, @MovieStoreGuy and myself are happy to be the codeowners for this extension.