Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASAP client auth missing on the list of components #6669

Closed
jpkrohling opened this issue Dec 9, 2021 · 3 comments
Closed

ASAP client auth missing on the list of components #6669

jpkrohling opened this issue Dec 9, 2021 · 3 comments
Assignees
@jamesmoessis
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jpkrohling
Copy link
Member

The ASAP client auth extension was added as part of the PR #6627, but it's missing from the list of components here:

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/internal/components/components.go

It should also be added to the extensions test (#6668 and #6667).
@jpkrohling jpkrohling added bug Something isn't working good first issue Good for newcomers labels Dec 9, 2021
@jpkrohling jpkrohling self-assigned this Dec 9, 2021
@jpkrohling
Copy link
Member Author

@jamesmoessis, would you like to work on this one?

@jamesmoessis
Copy link
Contributor

@jpkrohling sure thing I can pick this up

@jpkrohling jpkrohling mentioned this issue Dec 9, 2021
Closed
@jpkrohling jpkrohling assigned jamesmoessis and unassigned jpkrohling Dec 9, 2021
@jpkrohling
Copy link
Member Author

I believe this has been done already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesmoessis jamesmoessis

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @jamesmoessis